config(amazonq): Decouple LSP from vector index creation; start LSP by default #4978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
force-pushed
the
project-context-process
branch
from
6c73a33 to
0e53a01
Compare
Will-ShaoHua
changed the title
leigaol
reviewed
Oct 17, 2024
| if (isIndexSuccess) isIndexComplete.set(true) | ||
| return@launch | ||
| if (CodeWhispererSettings.getInstance().isProjectContextEnabled()) { | ||
| val isIndexSuccess = index() |
Contributor
There was a problem hiding this comment.
Here you need to call index() regardless of whether projectContext is enabled or not. If enabled, call it with config 'all' otherwise config 'default'
Contributor
Author
There was a problem hiding this comment.
nah this one doesn't have the latest lsp API
Contributor
Author
There was a problem hiding this comment.
it's still the old one which only does chat vector
6 tasks
leigaol
reviewed
Oct 21, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/project/ProjectContextProvider.kt
Show resolved
Hide resolved
leigaol
approved these changes
Oct 21, 2024
Contributor
Author
|
@rli i will add test as a followup |
rli
approved these changes
Oct 21, 2024
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-jetbrains
that referenced
this pull request
Oct 22, 2024
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-jetbrains
that referenced
this pull request
Oct 22, 2024
Will-ShaoHua
added a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparation work for #4976
implementation of aws/aws-toolkit-vscode#5702
Description
Current LSP start is coupled with vector index creation, this should be decoupled. We will be having new releases in the LSP to build some other indexes for everyone very soon ( not computation expensive as vector index), therefore we need to start LSP by default. The vector indexing, as a computational expensive index, will be only enabled if opt-in.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.